-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reconciler default timout, cluster and machine scopes, machine Reconcile
function, and InstanceStatus
enums
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
luthermonson,
dennisme and
a team
and removed request for
luthermonson and
dennisme
November 3, 2023 08:07
zliang-akamai
changed the title
Add reconciler default timout,
Add reconciler default timout, cluster scope, Nov 3, 2023
LinodeClients
, and InstanceStatus
LinodeClients
, and InstanceStatus
ChihweiLHBird
force-pushed
the
zhiwei/base1
branch
from
November 3, 2023 08:14
85b1f8f
to
dd786d4
Compare
luthermonson
reviewed
Nov 3, 2023
luthermonson
reviewed
Nov 3, 2023
ChihweiLHBird
force-pushed
the
zhiwei/base1
branch
from
November 5, 2023 07:14
63eb8d6
to
13d34e9
Compare
zliang-akamai
changed the title
Add reconciler default timout, cluster scope,
Add reconciler default timout, cluster and machine scopes, and Nov 5, 2023
LinodeClients
, and InstanceStatus
InstanceStatus
zliang-akamai
changed the title
Add reconciler default timout, cluster and machine scopes, and
Add reconciler default timout, cluster and machine scopes, machine Nov 5, 2023
InstanceStatus
Reconcile
function, and InstanceStatus
enums
luthermonson
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
…econcile` function, and `InstanceStatus` enums (#24) * Add `LinodeClients` and `InstanceStatus` * Add default reconciler timeout * go mod tidy * Add cluster scope * Correct naming * Add linode client directly to * Bump linodego to 1.24.1 * Implemented multiple functions for the cluster scope * Added MachineScope * Fill up Reconcile function * Add newly implemented packages to docker file * go mod tidy --------- Co-authored-by: Zhiwei Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some basic components
Related issue: #11